[Daily Color Clock] App rework #4102
Conversation
…ction call to avoid potential memory leaks
Added initial changelog entries for version 0.01 and 0.02.
Expanded the README to include details about the color queue system, settings for showing/hiding widgets, regenerating the color queue, and adding custom colors.
There was a problem hiding this comment.
Pull request overview
This PR reworks the Daily Color Clock app to implement a queue-based color system that prevents consecutive days from showing the same color. The refactoring replaces the old random selection mechanism with a shuffled queue that regenerates when exhausted, improves the settings interface to dynamically generate menu items from a color list, and adds several new color options.
- Implements color queue system to prevent back-to-back duplicate colors
- Refactors settings page to use dynamic menu generation from a colors array
- Adds 10 new colors including various dithered options (Light Pink, Dark Pink, Lime Green, Teal, Sea Green, Maroon, Brown, Peach)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/dailycolorclk/settings.js | Refactored to use a colors array for dynamic menu generation, added color queue management functions, and removed hardcoded color settings |
| apps/dailycolorclk/app.js | Implemented queue-based color rotation with shuffle algorithm, removed old random color selection, and improved code structure |
| apps/dailycolorclk/metadata.json | Updated version to 0.02, removed default.json from storage, and cleaned up description |
| apps/dailycolorclk/default.json | File removed as app now auto-generates queue |
| apps/dailycolorclk/README.md | Updated documentation to explain queue system and how to add custom colors |
| apps/dailycolorclk/ChangeLog | Added changelog entry for version 0.02 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Mind if I swap this to a draft PR? I'll not have much time over the next few weeks so having it in draft while it's still being worked on means me (or the other maintainers) won't get bogged into the changes until it's ready :) |
|
This actually should be good to go as of right now - I've finished all the changes. |
|
Sorry - just fixed a couple of things to make everything bug-free |
|
Ok everything should be good now, so @bobrippling if we want to get this in, it's ready to go! |
Added information about battery-friendliness and background handling.
|
Cool, thanks! |
2 participants
This changes the app to use a color queue, preventing duplicate colors back to back, reworks the settings page to use a list rather than hardcoded colors, adds new colors, and removed the old defaults.json as it now automatically generates a queue.