-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[iOS] Add automatic app name detection #4108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added information about automatic detection of app names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements automatic app name detection for iOS notifications by parsing bundle identifiers (e.g., com.apple.FindMy → Find My). The feature is controlled by a new "Auto-Detect App Names" setting that defaults to off, and auto-detected names are marked with a * to indicate they may not be perfect.
Key changes:
- Added automatic app name detection from bundle IDs using string manipulation (camelCase splitting, acronym handling)
- Removed many hardcoded app name mappings that can now be auto-detected
- Added new setting toggle in the iOS Integration app to enable/disable auto-detection
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/ios/settings.js | Adds new "Auto-Detect App Names" toggle setting |
| apps/ios/metadata.json | Bumps version to 0.22 and updates description text |
| apps/ios/boot.js | Implements app name detection algorithm, removes redundant app name mappings, adds logic to parse bundle IDs |
| apps/ios/README.md | Documents the new Auto-Detect App Names setting |
| apps/ios/ChangeLog | Adds entry for version 0.22 with feature description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Leaving this to Gordon for when he's back. Core app and I don't have a iDevice. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Ah - one issue with marking the names with a Edit: just made PR #4110 to fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Removed Netflix from the application list and added several new applications including Philips Hue, Google services, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/ios/README.md
Outdated
| installed, non-european (ISO8859-1) characters won't be displayed. If `Disable UTF8` | ||
| is true *or no fonts library is installed*, text from iOS is converted to ISO8859-1, and known characters with equivalents | ||
| within that range are converted (so text will display without a font library). | ||
| * `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.Apple.FindMy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected. |
Copilot
AI
Jan 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example in the documentation uses com.Apple.FindMy but the actual Bundle ID for Find My is com.apple.findmy (all lowercase). The example should be corrected to match the actual Bundle ID format used in the code.
| * `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.Apple.FindMy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected. | |
| * `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.apple.findmy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
Thanks, this looks great! I'm interested in what others think but my gut instinct is to not include the This is only the app source, so it's not really the end of the world if it's wrong occasionally. Having the ... also it means we don't need #4110 |
Removed unnecessary asterisk from name variable.
|
Just removed the |
This stems from this discussion, where a new way of determining app names was suggested by @gfwilliams. This PR implements that, with a setting (off by default) to enable that. This has been tested, and works well.