Skip to content

Conversation

@RKBoss6
Copy link
Contributor

@RKBoss6 RKBoss6 commented Dec 31, 2025

This stems from this discussion, where a new way of determining app names was suggested by @gfwilliams. This PR implements that, with a setting (off by default) to enable that. This has been tested, and works well.

Copilot AI review requested due to automatic review settings December 31, 2025 04:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements automatic app name detection for iOS notifications by parsing bundle identifiers (e.g., com.apple.FindMyFind My). The feature is controlled by a new "Auto-Detect App Names" setting that defaults to off, and auto-detected names are marked with a * to indicate they may not be perfect.

Key changes:

  • Added automatic app name detection from bundle IDs using string manipulation (camelCase splitting, acronym handling)
  • Removed many hardcoded app name mappings that can now be auto-detected
  • Added new setting toggle in the iOS Integration app to enable/disable auto-detection

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
apps/ios/settings.js Adds new "Auto-Detect App Names" toggle setting
apps/ios/metadata.json Bumps version to 0.22 and updates description text
apps/ios/boot.js Implements app name detection algorithm, removes redundant app name mappings, adds logic to parse bundle IDs
apps/ios/README.md Documents the new Auto-Detect App Names setting
apps/ios/ChangeLog Adds entry for version 0.22 with feature description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thyttan
Copy link
Collaborator

thyttan commented Dec 31, 2025

Leaving this to Gordon for when he's back. Core app and I don't have a iDevice.

RKBoss6 and others added 2 commits December 31, 2025 11:20
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Dec 31, 2025

Ah - one issue with marking the names with a * - It changes the src, so any app icons won't get shown. I don't feel comfortable with not showing a marker, in case it detects a name wrong and the user is confused, so should we make a modification to the app icons to ignore special signs like * when determining what icon to show?

Edit: just made PR #4110 to fix this

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed Netflix from the application list and added several new applications including Philips Hue, Google services, and more.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

installed, non-european (ISO8859-1) characters won't be displayed. If `Disable UTF8`
is true *or no fonts library is installed*, text from iOS is converted to ISO8859-1, and known characters with equivalents
within that range are converted (so text will display without a font library).
* `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.Apple.FindMy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected.
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example in the documentation uses com.Apple.FindMy but the actual Bundle ID for Find My is com.apple.findmy (all lowercase). The example should be corrected to match the actual Bundle ID format used in the code.

Suggested change
* `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.Apple.FindMy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected.
* `Auto-Detect App Names` - Enables automatic detection of app names from the last item of the Bundle Identifier (`com.apple.findmy` --> `Find My`). Detected app names are marked with a `*`, in case of a false/wrong app name detected.

Copilot uses AI. Check for mistakes.
RKBoss6 and others added 2 commits January 2, 2026 12:23
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
@gfwilliams
Copy link
Member

Thanks, this looks great! I'm interested in what others think but my gut instinct is to not include the * and to turn it on by default.

This is only the app source, so it's not really the end of the world if it's wrong occasionally. Having the * on every detected app name is going to be annoying and will lead to people doing PRs to add translations for the app name just to get rid of it, which goes against the whole point of this PR.

... also it means we don't need #4110

Removed unnecessary asterisk from name variable.
@RKBoss6
Copy link
Contributor Author

RKBoss6 commented Jan 7, 2026

Just removed the * from the end, I'll test this more though.

@RKBoss6 RKBoss6 marked this pull request as draft January 7, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants