fix(driver/mbim): better support for single slot devices#416
Merged
damonto merged 1 commit intoestkme-group:mainfrom Mar 5, 2026
Merged
Conversation
Modems that only have one sim slot may respond with NO_DEVICE_SUPPORT when we try to request the sim slot mapping in preparation for sim selection. This is (arguably) correct behavior when we're trying to select a sim slot that isn't there, but when we want to access slot 0, we shouldn't complain about it. So catch the situation where we receive the NO_DEVICE_SUPPORT error and consider the switch action successful if we're trying to access the first and only sim slot. While we're here, slightly improve two error lines to better indicate what's going wrong. Tested with EM7590 and EM9291 configured for only a single sim slot (`AT!CUSTOM="UIM2ENABLE",0`). Signed-off-by: Frans Klaver <frans.klaver@vislink.com>
damonto
approved these changes
Feb 3, 2026
CoelacanthusHex
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modems that only have one sim slot may respond with NO_DEVICE_SUPPORT when we try to request the sim slot mapping in preparation for sim selection. This is (arguably) correct behavior when we're trying to select a sim slot that isn't there, but when we want to access slot 0, we shouldn't complain about it.
So catch the situation where we receive the NO_DEVICE_SUPPORT error and consider the switch action successful if we're trying to access the first and only sim slot.
While we're here, slightly improve two error lines to better indicate what's going wrong.
Tested with EM7590 and EM9291 configured for only a single sim slot (
AT!CUSTOM="UIM2ENABLE",0).