Add Tauri-based companion desktop app for presentation overlays and effects#338
Add Tauri-based companion desktop app for presentation overlays and effects#338
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Comment |
Adjust whitespace-only lines in desktop demo blurring and overlay app codebaseUpdate blank lines across the desktop demo blurring and overlay app files without changing logic. 📍Where to StartStart with the highest-diff file in the desktop demo app entry point, typically 📊 Macroscope summarized d3ae8fd. 9 files reviewed, 17 issues evaluated, 10 issues filtered, 5 comments posted. View details |
Co-authored-by: estruyf <2900833+estruyf@users.noreply.github.com>
Deploying demo-time with
|
| Latest commit: |
d3ae8fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a34741db.demo-time.pages.dev |
| Branch Preview URL: | https://copilot-add-demo-overlay-app.demo-time.pages.dev |
Co-authored-by: estruyf <2900833+estruyf@users.noreply.github.com>
|
Co-authored-by: estruyf <2900833+estruyf@users.noreply.github.com>
Co-authored-by: estruyf <2900833+estruyf@users.noreply.github.com>
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| import react from "@vitejs/plugin-react"; | ||
|
|
||
| // @ts-expect-error process is a nodejs global | ||
| const host = process.env.TAURI_DEV_HOST; |
There was a problem hiding this comment.
hmr.host uses wildcard hosts (e.g., 0.0.0.0/::), producing an unroutable client URL (ws://0.0.0.0:1421). Consider normalizing wildcard hosts to a concrete client host (e.g., localhost) for HMR.
-const host = process.env.TAURI_DEV_HOST;
+const host = process.env.TAURI_DEV_HOST;
+const hmrHost = host && (host === "0.0.0.0" || host === "::") ? "localhost" : host;
@@
- host,
+ hmrHost,🚀 Want me to fix this? Reply ex: "fix it for me".
apps/companion-app/src/App.tsx
Outdated
| }; | ||
|
|
||
| const handleShowMessage = async () => { | ||
| try { |
There was a problem hiding this comment.
Pressing Enter submits an empty message while the Show button is disabled when !message. Consider adding a guard in handleShowMessage (or in the key handler) so both paths are consistent.
| try { | |
| if (!message) return; | |
| try { |
🚀 Want me to fix this? Reply ex: "fix it for me".
| } | ||
| } | ||
| } | ||
| "zoom.set" => { |
There was a problem hiding this comment.
zoom.set casts an unvalidated f64 to f32, which can yield NaN/±INF and break state and API consistency (others clamp to [1.0, 5.0]). Consider rejecting non‑finite input and clamping to [1.0, 5.0] before casting and updating state.
🚀 Want me to fix this? Reply ex: "fix it for me".
…ainability Co-authored-by: estruyf <2900833+estruyf@users.noreply.github.com>
- Added API server with endpoints for action execution, status retrieval, and health check. - Created action handling for spotlight, blur, and zoom functionalities. - Implemented overlay state management with blur, spotlight, and zoom controls. - Developed user interface components for managing overlay effects and displaying messages. - Integrated keyboard shortcuts for quick access to functionalities. - Established communication between frontend and backend using Tauri commands and events.
…nd settings modes, and make webview background transparent
- Deleted `api_server_old.rs` and `lib_old.rs` to clean up the codebase. - Updated `lib.rs` to remove references to the old API server and adjusted the overlay mode logic. - Modified CSS files to enhance the overlay appearance and removed old styles. - Removed old React component `App_old.tsx` to streamline the application structure.
…ty management in overlay and settings modes
…ed UI consistency
|
| view_mode: State<ViewModeState>, | ||
| blur_state: State<BlurStateArc>, | ||
| ) -> Result<(), String> { | ||
| // Reset blur state |
There was a problem hiding this comment.
Suggestion: Resolve get_webview_window("main") first and error if None; only then update ViewMode, window properties, and emit to avoid inconsistent state when the window is missing.
🚀 Want me to fix this? Reply ex: "fix it for me".
| -d "$data") | ||
| fi | ||
|
|
||
| http_code=$(echo "$response" | tail -n1) |
There was a problem hiding this comment.
If curl fails, response is empty and http_code becomes blank, producing a confusing HTTP line. Consider checking curl’s exit status and failing early with a clear message.
+ curl_status=$?
+ if [ $curl_status -ne 0 ]; then
+ echo -e "${RED}✗ FAIL (curl error $curl_status)${NC}"
+ echo ""
+ sleep 0.5
+ return
+ fi🚀 Want me to fix this? Reply ex: "fix it for me".
| drop(blur); | ||
|
|
||
| // Change view mode | ||
| let mut mode = view_mode.lock().map_err(|e| e.to_string())?; |
There was a problem hiding this comment.
Suggestion: Update view_mode only after window operations succeed (or revert on error) so state always matches the UI.
🚀 Want me to fix this? Reply ex: "fix it for me".
| let _tray = TrayIconBuilder::new() | ||
| .icon(app.default_window_icon().unwrap().clone()) | ||
| .menu(&menu) | ||
| .show_menu_on_left_click(false) | ||
| .on_menu_event(move |app, event| { |
There was a problem hiding this comment.
app.default_window_icon().unwrap() will panic if no icon is set in tauri.conf.json. Consider handling None and build the tray without a custom icon (or use a fallback) to avoid a runtime panic.
- let _tray = TrayIconBuilder::new()
- .icon(app.default_window_icon().unwrap().clone())
- .menu(&menu)
- .show_menu_on_left_click(false)
- .on_menu_event(move |app, event| {
+ let mut tray_builder = TrayIconBuilder::new();
+ if let Some(icon) = app.default_window_icon() {
+ tray_builder = tray_builder.icon(icon.clone());
+ }
+ let _tray = tray_builder
+ .menu(&menu)
+ .show_menu_on_left_click(false)
+ .on_menu_event(move |app, event| {🚀 Want me to fix this? Reply ex: "fix it for me".
| settings: SettingsState, | ||
| ) -> Result<(), Box<dyn std::error::Error>> { | ||
| let port = { | ||
| let s = settings.lock().unwrap(); |
There was a problem hiding this comment.
Using unwrap() on settings.lock() can panic if the mutex is poisoned. Consider recovering (e.g., take the inner guard) to avoid crashing and to match the graceful handling used elsewhere.
| let s = settings.lock().unwrap(); | |
| let s = settings.lock().unwrap_or_else(|e| e.into_inner()); |
🚀 Want me to fix this? Reply ex: "fix it for me".
Description
Implements a cross-platform desktop companion app for Demo Time that provides screen overlay controls during presentations: blur effects, spotlight mode, zoom functionality, and message displays. Eliminates flickering during transitions and enables professional presentation effects via HTTP API or keyboard shortcuts.
Architecture:
Integration example:
{ "action": "executeCommand", "command": "workbench.action.terminal.sendSequence", "args": { "text": "curl -X POST http://127.0.0.1:42042/action -H 'Content-Type: application/json' -d '{\"action\": \"blur.toggle\"}'\n" } }Key implementation details:
CommandOrControlmodifierlib.rs(commands),api_server.rs(HTTP),overlay.rs(window management)API actions:
blur.{toggle|on|off}- Screen blur during transitionsspotlight.{toggle|on|off}- Cursor area highlightingzoom.{in|out|reset|set}- Magnification control (1.0x-5.0x)message.{show|hide}- Text overlay displayDocumentation:
README.md- User guide with API referenceINTEGRATION.md- VS Code integration patternsCONTRIBUTING.md- Developer setup and architectureQUICKSTART.md- 5-minute build and test guideexamples/demo-with-companion.json- Full demo walkthroughexamples/test-api.sh- API endpoint validation scriptDeferred to future PRs:
Type of change
Checklist
Screenshots (if applicable)
N/A - Desktop app UI would require manual build to capture. Control panel shows:
Additional context
Build requirements:
libwebkit2gtk-4.1-dev,librsvg2-dev, standard build toolsTesting performed:
cargo check)Dependencies added:
@tauri-apps/api^2 - Frontend bindings@tauri-apps/cli^2 - Build toolingwarp0.3 - HTTP server framework (Rust)tokio1 - Async runtime (Rust)Project structure:
The app is production-ready for manual distribution. CI/CD integration and automated builds can be added in follow-up PRs.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.nx.app/usr/local/bin/node /usr/local/bin/node ./bin/post-install(dns block)esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https --hash-style=gnu --as-needed 64-REDACTED-linux-gnu/bin/gcc-ld/ld.lld -z relro -o /home/REDACTED/work/vscode-demo-time/vscode-demo-time/apps/companion-app/src-tauri/target/debug/deps/libfutures_macro-743b16a35ede7996.so /usr/lib/gcc/x86_64-linux-gnu/13/../../../x86_64-linux-gnu/crti.o /usr/lib/gcc/x86_64-linux-gnu/13/crtbeginS.o -L/tmp/rustccJYeDL/raw-dylibs -L/home/REDACTED/.rustup/toolchains/stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/lib _bui��(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.