materialize-mysql: implement 'Additional Table Create SQL'#4263
Open
jacobmarble wants to merge 1 commit intomainfrom
Open
materialize-mysql: implement 'Additional Table Create SQL'#4263jacobmarble wants to merge 1 commit intomainfrom
jacobmarble wants to merge 1 commit intomainfrom
Conversation
jacobmarble
commented
Apr 17, 2026
| @@ -1,2 +1,2 @@ | |||
| will:secret1234@tcp(example.com:3306)/somedb?clientFoundRows=true&connectionAttributes=program_name%3AEstuary+materialize-mysql | |||
| will:secret1234@tcp(example.com:3306)/somedb?clientFoundRows=true&connectionAttributes=program_name%3AEstuary+materialize-mysql&multiStatements=true | |||
Contributor
Author
There was a problem hiding this comment.
FYI multiStatements=true allows users to provide multiple statements to the additional SQL value. Postgres allows multiple statements by default, MySQL requires it to be explicitly enabled.
danielnelson
approved these changes
Apr 17, 2026
| res = tc.Resource.(tableConfig) | ||
| } | ||
|
|
||
| if _, err := c.db.ExecContext(ctx, tc.TableCreateSql); err != nil { |
Contributor
There was a problem hiding this comment.
Can these statements be in a transaction so all tables are created atomically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Closes #4028
Implement the "Additional Table Create SQL" materialize-mysql feature.
The feature is slightly different to the materialize-postgres equivalent - MySQL cannot perform SQL statements after
CREATE TABLEin one transaction, hence "Additional SQL statement(s) to be run after the table is created."Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
Docs updated at estuary/flow#2869
Notes for reviewers:
(anything that might help someone review this PR)