fix(es_extended): remove admin fallback for superadmin group#1743
Open
Kenshiin13 wants to merge 1 commit intodevfrom
Open
fix(es_extended): remove admin fallback for superadmin group#1743Kenshiin13 wants to merge 1 commit intodevfrom
Kenshiin13 wants to merge 1 commit intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the hardcoded behavior that automatically converted the “superadmin” group to “admin.” From now on, “superadmin” is treated as a valid group on its own. Opinionated logic like this has no place in a framework — developers should have full control over how their permission groups are defined and used.
Motivation
ESX previously forced “superadmin” to fall back to “admin,” removing flexibility and making it harder for server owners to structure permissions their own way. A framework should never enforce arbitrary conventions or override developer intent. This change ensures group handling is neutral, predictable, and fully customizable.
PR Checklist