feat(chunks): add POST /v1/chunks endpoint

[leoguillaume]

No description provided.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 592-document-add-postpatchdelete-v1chunks

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

To fix the problem, the call to _upsert must supply all required arguments, specifically elasticsearch_vector_store and elasticsearch_client. The _upsert method signature is already correct and makes use of these parameters when performing the final upsert into Elasticsearch, so we should not change the method definition or remove its parameters. Instead, we update the _vectorize (or equivalent) method around line 333–382 to pass the two missing keyword arguments when invoking _upsert. Both elasticsearch_vector_store and elasticsearch_client are already in scope in this method (they are used at line 354 to compute last_chunk_id), so we simply forward them to _upsert. No new imports or definitions are needed; this is a straightforward addition of two keyword arguments at the call site, preserving existing functionality.

Concretely, in api/helpers/_documentmanager.py, in the block starting at line 366 where await self._upsert( is called, add elasticsearch_vector_store=elasticsearch_vector_store, and elasticsearch_client=elasticsearch_client, to the argument list, aligning with the parameters declared in _upsert at line 520.

In general, this pattern is fixed by ensuring the local variable is initialized on all code paths before any possible use. That can be done by either (a) initializing it to a default value before any conditional branches, or (b) restructuring the code so that any reads are strictly dominated by the write (for example, by nesting the later logic inside the same if block).

Here, the least intrusive fix that preserves existing behavior is to initialize chunks to an empty list before the if file: block. Because all uses of chunks are inside if file: blocks, this will not change behavior: when file is truthy, chunks will be overwritten by the parsed/split content as before; when file is falsy, the lower if file: will skip the entire vectorization branch, and the initial empty list will never be used. To implement this, add chunks: list[str] = [] (or simply chunks = []) immediately after computing document_name and before the if file: block in api/helpers/_documentmanager.py.

No new imports or helper methods are required; we only add one local initialization line.