Skip to content

Bump go to 1.25.8#1156

Open
shuan1026 wants to merge 2 commits intoetcd-io:mainfrom
shuan1026:bump-main-go-v1.25.7-bbolt
Open

Bump go to 1.25.8#1156
shuan1026 wants to merge 2 commits intoetcd-io:mainfrom
shuan1026:bump-main-go-v1.25.7-bbolt

Conversation

@shuan1026
Copy link

@shuan1026 shuan1026 commented Mar 2, 2026

Ref: etcd-io/etcd#21364
Ref: etcd-io/etcd#21458

From https://go.dev/doc/devel/release#go1.25.0

go1.25.7 (released 2026-02-04) includes security fixes to the go command and the crypto/tls package, as well as bug fixes to the compiler and the crypto/x509 package.
go1.25.8 (released 2026-03-05) includes security fixes to the html/template, net/url, and os packages, as well as bug fixes to the go command, the compiler, and the os package. See the Go 1.25.8 milestone on our issue tracker for details.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shuan1026
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member

ivanvc commented Mar 3, 2026

Thanks for the pull request, @shuan1026. Here we need to bump the golangci-lint version defined: in

The minimum version with Go 1.25 support is v2.4.0. But I'd suggest using the latest v2.10.1.

@shuan1026
Copy link
Author

Thanks for the pull request, @shuan1026. Here we need to bump the golangci-lint version defined: in

The minimum version with Go 1.25 support is v2.4.0. But I'd suggest using the latest v2.10.1.

Done. Thanks for the review.

@ivanvc ivanvc mentioned this pull request Mar 4, 2026
18 tasks
@ahrtr
Copy link
Member

ahrtr commented Mar 4, 2026

/ok-to-test

@shuan1026 shuan1026 force-pushed the bump-main-go-v1.25.7-bbolt branch 2 times, most recently from b511b8e to a90b584 Compare March 8, 2026 14:05
@shuan1026 shuan1026 changed the title Bump go to 1.25.7 Bump go to 1.25.8 Mar 8, 2026
@ahrtr
Copy link
Member

ahrtr commented Mar 8, 2026

pls rebase and squash the commits, thx

Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
@shuan1026 shuan1026 force-pushed the bump-main-go-v1.25.7-bbolt branch from a90b584 to ff12bfa Compare March 9, 2026 08:06
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Mar 9, 2026
@ahrtr
Copy link
Member

ahrtr commented Mar 9, 2026

Pls fix the workflow failure. It seems that the env variable GOTOOLCHAIN isn't correctly configured. cc @ivanvc @joshjms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants