Merged
Conversation
Signed-off-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com>
VihasMakwana
force-pushed
the
tx-check-panic
branch
from
e5d1518 to
e8dfa8c
Compare
Contributor
Author
|
@ahrtr Could you take a look when you're around? There's only one commit in this PR and it should be good to go . |
Member
|
/ok-to-test |
Contributor
Author
|
Nice! CI is green. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, VihasMakwana The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tx.checkis called in a goroutine insidetx.Checkwhen using strict mode.tx.checkperforms checks on page flags and page id and it panics in the goroutine if type the database is corrupted. This panic, however, is not recovered and can cause the entire process to crash.This PR adds
recovercall and passes the error to the caller.Testing
I have added a unit test for this fix. This test would fail without the recover.