Fix cert-manager scheme registration #234
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArkaSaha30 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
This commit will fix default always install cert-manager to optional when cert-manager specific test is run. Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
ArkaSaha30
force-pushed
the
fix-cert-manager-scheme
branch
from
a89ca02 to
02b62e9
Compare
Contributor
Author
|
/test pull-etcd-operator-test-e2e |
ArkaSaha30
force-pushed
the
fix-cert-manager-scheme
branch
from
95e3cec to
2519f3e
Compare
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
ArkaSaha30
force-pushed
the
fix-cert-manager-scheme
branch
from
2519f3e to
3e0b9fa
Compare
ArkaSaha30
changed the title
Contributor
Author
|
/test pull-etcd-operator-test-e2e |
ahrtr
reviewed
Jan 20, 2026
Comment on lines
+299
to
+300
| leaderID: | ||
| description: LeaderID is the hex-encoded ID of the current etcd cluster |
Member
There was a problem hiding this comment.
for this kind of change, it should be in a separate PR, so that it can be merged soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
Fixes: #232