Merge pull request #20751 from ahrtr/20251002_log

[release-3.5] server/embed: Log EOF on DEBUG in TLS handshake

Author: jmhbnz

server/embed/config_logging.go

@@ -19,6 +19,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"io"
 	"io/ioutil"
 	"net/url"
 	"os"
@@ -149,6 +150,12 @@ func (cfg *Config) setupLogging() error {
 
 		logTLSHandshakeFailureFunc := func(msg string) func(conn *tls.Conn, err error) {
 			return func(conn *tls.Conn, err error) {
+				// Log EOF errors on DEBUG not to spam logs too much.
+				logFunc := cfg.logger.Warn
+				if errors.Is(err, io.EOF) {
+					logFunc = cfg.logger.Debug
+				}
+
 				state := conn.ConnectionState()
 				remoteAddr := conn.RemoteAddr().String()
 				serverName := state.ServerName
@@ -158,7 +165,7 @@ func (cfg *Config) setupLogging() error {
 					for i := range cert.IPAddresses {
 						ips[i] = cert.IPAddresses[i].String()
 					}
-					cfg.logger.Warn(
+					logFunc(
 						msg,
 						zap.String("remote-addr", remoteAddr),
 						zap.String("server-name", serverName),
@@ -167,7 +174,7 @@ func (cfg *Config) setupLogging() error {
 						zap.Error(err),
 					)
 				} else {
-					cfg.logger.Warn(
+					logFunc(
 						msg,
 						zap.String("remote-addr", remoteAddr),
 						zap.String("server-name", serverName),