-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Antithesis build #20406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Antithesis build #20406
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d95ced1
to
0d54ae9
Compare
…sing Signed-off-by: Marek Siarkowicz <[email protected]>
0d54ae9
to
bafe0dd
Compare
Ups not docker daemon available. |
@@ -15,6 +15,7 @@ build-all: | |||
@for platform in $(PLATFORMS); do \ | |||
$(MAKE) build-$${platform}; \ | |||
done | |||
$(MAKE) -C tests/antithesis antithesis-build-etcd-image-local antithesis-build-client-image antithesis-build-config-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that all Antithesis-related code, config, or scripts be scoped strictly within tests/antithesis/
. Since Antithesis is a commercial platform and this integration is optional, it's important we keep the core repo clean and avoid coupling external services into the main codebase.
Adding workflows is fine,
etcd/.github/workflows/antithesis-test.yml
Lines 68 to 71 in d02a151
- name: Build and push client image | |
working-directory: ./tests/antithesis | |
run: | | |
make antithesis-build-client-docker-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@serathius: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @fuweid @nwnt