Skip to content

Conversation

serathius
Copy link
Member

@k8s-ci-robot k8s-ci-robot requested review from fuweid and nwnt July 26, 2025 16:14
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/testing github_actions Pull requests that update GitHub Actions code approved size/M labels Jul 26, 2025
@serathius
Copy link
Member Author

Ups not docker daemon available.

@@ -15,6 +15,7 @@ build-all:
@for platform in $(PLATFORMS); do \
$(MAKE) build-$${platform}; \
done
$(MAKE) -C tests/antithesis antithesis-build-etcd-image-local antithesis-build-client-image antithesis-build-config-image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that all Antithesis-related code, config, or scripts be scoped strictly within tests/antithesis/. Since Antithesis is a commercial platform and this integration is optional, it's important we keep the core repo clean and avoid coupling external services into the main codebase.

Adding workflows is fine,

- name: Build and push client image
working-directory: ./tests/antithesis
run: |
make antithesis-build-client-docker-image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@k8s-ci-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-build bafe0dd link true /test pull-etcd-build
pull-etcd-govulncheck bafe0dd link true /test pull-etcd-govulncheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants