Fix flaky test embed.TestEnableAuth which can fail due to port conflict#21508
Fix flaky test embed.TestEnableAuth which can fail due to port conflict#21508jonathan-albrecht-ibm wants to merge 3 commits intoetcd-io:mainfrom
Conversation
'listen tcp 127.0.0.1:2380: bind: address already in use' errors when running tests. Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonathan-albrecht-ibm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @jonathan-albrecht-ibm. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
themavik
left a comment
There was a problem hiding this comment.
TestEnableAuth now wires Listen/Advertise/InitialCluster through testutil.NewConfigTestURLs like serve_test, so unix paths stay pid-scoped and the flake from clashing defaults should go away. nit: variable name testURLConfg looks like a typo for Config.
Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
|
TFTR @themavik! I have fixed the typo |
Add test utils to create unique urls for embed tests to fix
'listen tcp 127.0.0.1:2380: bind: address already in use'
errors when running
embedtests.