Skip to content

Fix flaky test embed.TestEnableAuth which can fail due to port conflict#21508

Open
jonathan-albrecht-ibm wants to merge 3 commits intoetcd-io:mainfrom
linux-on-ibm-z:embed-tests-url-uniquify
Open

Fix flaky test embed.TestEnableAuth which can fail due to port conflict#21508
jonathan-albrecht-ibm wants to merge 3 commits intoetcd-io:mainfrom
linux-on-ibm-z:embed-tests-url-uniquify

Conversation

@jonathan-albrecht-ibm
Copy link
Contributor

Add test utils to create unique urls for embed tests to fix

'listen tcp 127.0.0.1:2380: bind: address already in use'

errors when running embed tests.

  'listen tcp 127.0.0.1:2380: bind: address already in use'

errors when running tests.

Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonathan-albrecht-ibm
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @jonathan-albrecht-ibm. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@themavik themavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestEnableAuth now wires Listen/Advertise/InitialCluster through testutil.NewConfigTestURLs like serve_test, so unix paths stay pid-scoped and the flake from clashing defaults should go away. nit: variable name testURLConfg looks like a typo for Config.

Signed-off-by: Jonathan Albrecht <jonathan.albrecht@ibm.com>
@jonathan-albrecht-ibm
Copy link
Contributor Author

TFTR @themavik! I have fixed the typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants