Add simulation mode to model validation#309
Conversation
Signed-off-by: Joshua Zhang <joshuazh@microsoft.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joshuazh-x The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @joshuazh-x. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| if [ "$sim" = true ]; then | ||
| java -XX:+UseParallelGC -cp ${tooldir}/tla2tools.jar:${tooldir}/CommunityModules-deps.jar tlc2.TLC -config "${config}" "${spec}" -lncheck final -metadir "${statedir}" -fpmem 0.9 -workers auto -simulate | ||
| else | ||
| java -XX:+UseParallelGC -cp ${tooldir}/tla2tools.jar:${tooldir}/CommunityModules-deps.jar tlc2.TLC -config "${config}" "${spec}" -lncheck final -metadir "${statedir}" -fpmem 0.9 -workers auto | ||
| fi |
There was a problem hiding this comment.
Minor improvement
args=(
-config "${config}"
"${spec}"
-lncheck final
-metadir "${statedir}"
-fpmem 0.9
-workers auto
)
if [ "$sim" = true ]; then
args+=(-simulate)
fi
java -XX:+UseParallelGC -cp "${tooldir}/tla2tools.jar:${tooldir}/CommunityModules-deps.jar" tlc2.TLC "${args[@]}"
Add simulation mode to validate-model.sh, which will randomly walk in the state machine and is helpful for finding issues quickly.