[#510]: Fix Maestro CI script: dash rejects set -o pipefail - #511
Merged
Conversation
android-emulator-runner invokes script via /usr/bin/sh (dash), which rejects set -o pipefail. Wrap the body in a bash heredoc so harness can reach Gradle.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mattrace-gloo
marked this pull request as ready for review
September 11, 2026 21:46
mattrace-gloo
requested review from
B3RN153 and
JonathanSeehagen
as code owners
September 11, 2026 21:46
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes the #497 harness CI abort:
android-emulator-runnerrunsscriptunder Ubuntu dash, which rejectsset -o pipefail. Wrap the body in abashheredoc so the job can reach Gradle/Maestro. Also silences emulator metrics prompts with-no-metrics.Reviewer checklist
Refs #NNN— do not useCloses/Fixes/Resolves; useRefs: noneonly for explicit no-ticket chores)AGENTS.md)docs/guides/qa-process.md)Details
Refs #510
Follow-up to failed run https://github.com/eten-tech-foundation/fluent-mobile/actions/runs/34649217854 (
/usr/bin/sh: 1: set: Illegal option -o pipefail). Emulator boot was fine; Gradle never started.Needs QA?
docs/guides/qa-process.md)Type of change:
Technical changes
.github/workflows/maestro-android.yml— bash heredoc wrapper;-no-metricson emulator optionsdocs/guides/maestro.md— note about dash vs bashTesting
npm run format:check/lint/architecture-guard/typecheck/npm test -- --ci— passruby .github/scripts/check-action-pins.rb— passsh -c 'bash … heredoc'sanity — passcode-reviewer— APPROVEHow to verify
harness— must get past script entry into./gradlew :app:assembleRelease(may still fail later on signing/build; this PR only fixes the dash abort)Expected: No
Illegal option -o pipefail; Gradle logs appear in the emulator-runner step.Follow-ups
assembleRelease/ APK path if the next harness dispatch fails after this fix