[#516]: Migrate Maestro E2E to EAS Workflows - #518
Merged
Conversation
Use Expo-canonical type: maestro + e2e-test APK profile; drop the GHA emulator job and helper script.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mattrace-gloo
marked this pull request as ready for review
September 12, 2026 00:08
mattrace-gloo
requested review from
B3RN153 and
JonathanSeehagen
as code owners
September 12, 2026 00:08
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Hosted Maestro Android E2E now runs on EAS Workflows (
type: maestro) with an Android-onlye2e-testAPK profile. Removes the GitHub Actions emulator workflow andscripts/maestro-ci-emulator.shso we follow Expo’s canonical path instead of fighting GHA timeouts.Reviewer checklist
Refs #NNN— do not useCloses/Fixes/Resolves; useRefs: noneonly for explicit no-ticket chores)AGENTS.md)docs/guides/qa-process.md)Details
Refs #516
Replace GHA Maestro with
.eas/workflows/maestro-android.yml(build → conditional harness/smokes/multi-account). Manualworkflow_dispatchonly — not a PR merge gate. Local Debug+Metro Maestro scripts unchanged.Needs QA?
docs/guides/qa-process.md)Type of change:
Technical changes
.eas/workflows/maestro-android.yml— EASbuild+maestrojobs; suite input; preview secret hookseas.json— Android-onlye2e-testprofile (withoutCredentials, APK, preview env)package.json—maestro:eas→ pinnedeas-cli@24.3.0 workflow:run.github/workflows/maestro-android.ymlandscripts/maestro-ci-emulator.shdocs/guides/maestro.md,docs/ci.md,.eas/README.md,.github/README.md,docs/AGENT_ONBOARDING.mdTesting
npm run format:check,lint,architecture-guard,typecheck,npm test -- --ciworkflow_validatepassed for the Maestro workflow YAMLcode-reviewerShould-fixes applied (tag-based smokes path, preview secret scope note, pinned eas-cli)How to verify
.github/workflows/maestro-android.ymland that CI inventory / Maestro guide point at.eas/workflows/maestro-android.yml.EXPO_TOKEN+ EAS preview secrets for smokes):npm run maestro:eas -- -F suite=harnessand watch the EAS dashboard.MAESTRO_*as Secret vars on EAS preview, thensuite=smokes.Expected: Harness builds an
e2e-testAPK and runs.maestro/flows/smoke-launch.yamlon nested-virt; GHA no longer runs Maestro.Follow-ups
MAESTRO_*secrets (broader than old GHA job secrets — see maestro.md).