Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders Open Preview |
|
View your CI Pipeline Execution ↗ for commit acdbcf9.
☁️ Nx Cloud last updated this comment at |
irahopkinson
force-pushed
the
fix-insertion
branch
from
7937887 to
b74e61d
Compare
- fix renumbering if only one chapter or is last chapter - don't include `sid` for chapter or verse - add a space before a verse if needed - don't renumber if new USJ is loaded - refactor to use node transform (remove bad cascading update) - add tests and framework - also add `utilities` develop-in-app instructions - also remove redundant `await`s from tests
irahopkinson
force-pushed
the
fix-insertion
branch
from
b74e61d to
acdbcf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sidfor chapter or verseutilitiesdevelop-in-app instructionsawaits from tests