Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders Open Preview |
|
View your CI Pipeline Execution ↗ for commit 20ea904.
☁️ Nx Cloud last updated this comment at |
irahopkinson
force-pushed
the
fix-react-deps
branch
from
365f49a to
19f9837
Compare
- React Hook dependency warnings - wrap `handleInputSubmit` in useCallback and define it before it is used - also de-nest else-if - also don't need both `?` and `| undefined`
irahopkinson
force-pushed
the
fix-react-deps
branch
from
19f9837 to
20ea904
Compare
samueljd
approved these changes
Mar 14, 2025
Contributor
samueljd
left a comment
samueljd
left a comment
There was a problem hiding this comment.
Thanks, This doesn't break anything for Scribe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleInputSubmitin useCallback and define it before it is used?and| undefinedNote
There are still more warnings but you might need to look at those.