platform: PT-3799 Remove extra space before inline markers and annotations#454
Merged
jolierabideau merged 6 commits intomainfrom Feb 27, 2026
Merged
Conversation
…ors into pt-3799-extra-space-before-markers
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders Open Preview |
jolierabideau
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
irahopkinson
requested changes
Feb 26, 2026
Collaborator
irahopkinson
left a comment
irahopkinson
left a comment
There was a problem hiding this comment.
Good job. Please consider other inline nodes as per my comment.
Collaborator
|
Also if you are going to do a Squash and merge then we are fine but if you are going to Create a merge commit then we need to do a little git magic first. Let me know if you need help with that. |
irahopkinson
approved these changes
Feb 26, 2026
Collaborator
irahopkinson
left a comment
irahopkinson
left a comment
There was a problem hiding this comment.
👍 LGTM thanks for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextSpacingPluginskip adding a trailing space when theTextNode's next sibling is aCharNodeorTypedMarkNode$textNodeTrailingSpaceTransformfunction descriptionTextNodes when next sibling is aCharNode, not adding trailing space when next sibling is aCharNode, not adding trailing space when next sibling is aTypedMarkNodeuseUsfmMakersForMenutouseUsfmMarkersForMenuinshared-reactlibrary andscribepackage.