Removed reorganizing verse numbers automatically

[tjcouch-sil]

Also explained nx extract-api so I don't have to go find Ira's note about it on my previous PR every time I make changes ;)

I don't know if this functionality is still desired in some editor usage contexts outside of Platform.Bible; let me know if you'd like me to add a prop so we can just turn this off in Platform.Bible and leave it otherwise.

---

---

This change is 

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

• dev:perf-react
• dev:perf-vanilla
• dev:platform

[jolierabideau]

Looks good to me, just one question.

[irahopkinson]

👍 LGTM but consider 2 posts.

[irahopkinson]

@irahopkinson reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on tjcouch-sil).

---

libs/shared-react/src/plugins/usj/UsjNodesMenuPlugin.tsx line 45 at r1 (raw file):

  const [editor] = useLexicalComposerContext();
  useVerseCreated(editor);

NIT you could have parametrized this and left the code in so platform-editor could just turn it off by default. However this is git so the code isn't lost.

Code quote:

  const [editor] = useLexicalComposerContext();
  useVerseCreated(editor);

[tjcouch-sil]

@tjcouch-sil made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on irahopkinson and jolierabideau).

---

libs/shared-react/src/plugins/usj/UsjNodesMenuPlugin.tsx line 45 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

NIT you could have parametrized this and left the code in so platform-editor could just turn it off by default. However this is git so the code isn't lost.

It was already partially broken (copy/paste didn't work right as detailed in the work item, and my testing seemed to indicate making verse numbers didn't work quite right in some contexts), so parameterizing it doesn't really feel that useful in my mind unless someone else actually wants to use and maintain it as I mentioned in my PR description. Felt like a YAGNI.

Let me know, and I can add it back in exactly as it was if you want.

[irahopkinson]

thanks for this.

@irahopkinson reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jolierabideau).

[jolierabideau]

@jolierabideau reviewed all commit messages and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on tjcouch-sil).

[devin-ai-integration]

Devin Review found 1 new potential issue.

View 6 additional findings in Devin Review.

[irahopkinson]

@irahopkinson reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on tjcouch-sil).

[tjcouch-sil]

@tjcouch-sil resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on tjcouch-sil).