Fix high CPU usage from shared list reference in select() event loop #361
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed line 264 in etesync_dav/radicale_main/server.py from: rlist = xlist = [] to: rlist, xlist = [], [] This fixes a critical bug where both variables pointed to the same list, causing select.select() to receive the same sockets for both readable and exceptional conditions, leading to inefficient event handling and high CPU usage. Co-authored-by: Victor239 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #206 and #344. I had been having these CPU usage issues for a long time, this fix completely solved my issues.
The server event loop was consuming up to 100% CPU due to a single-line bug where
rlistandxlistreferenced the same list object, causingselect.select()to monitor identical sockets for both read and exceptional events.Changes:
etesync_dav/radicale_main/server.py:This ensures
xlistremains empty as intended, allowing the event loop to properly block until events occur instead of busy-looping.