-
Notifications
You must be signed in to change notification settings - Fork 67
Fix kinematic tree bug that breaks SMPLH loading #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fix Pose Editing
|
It seems like the workflow is failing because Python 3.7 is not available on Ubuntu 24.04, which is used by ubuntu-latest runners. I believe the workflow should be upgraded to at least python 3.8. (which my last commit do) |
|
Hey @MarilynKeller I've also faced the same issue, and I tried to fix it with this. It is similar in essence, but also fixes the skeleton loading and keeps the option to use smplx or smplh model with articulated hands. |
|
I think your version results in displaying the SMPLH joints for each hand joint right? I was hesitant to do so as well as the result visual is a bit cluttered. Maybe ideal would be an additional parameter to the sequence to control or not to display the hands. |
In the current version, the SMPLH model is not loading anymore. This is caused by a change hat was made in the MANO commit:
https://github.com/MarilynKeller/aitviewer/blob/8fb6d4661303579ef04b3bf63ac907dbaecff2ff/aitviewer/renderables/smpl.py#L162C71-L162C86
In the previous version, only the body pose parameters would be passed here, not the hands.
skeletononly contains the body skeleton, hence the crash.I reverted this change such that only the root orientation and the body pose are passed.
The propose fix does not change the behavior with MANO.
Also, note that I am on python 3.12.3 and it is running with "moderngl-window==2.4.6". Setup.py currently limits the python version to < 3.11.