Skip to content

Conversation

@busolind
Copy link
Contributor

@busolind busolind commented Jun 5, 2025

No description provided.

@busolind busolind requested a review from mpasserini as a code owner June 5, 2025 08:59
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style comments. Can't comment on the contents themselves, but looks good to me on a high level.

@busolind busolind force-pushed the storage-update-1 branch from 404e311 to 2af84e4 Compare June 5, 2025 13:50

First, a bucket policy needs to be written:

```json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```json
```console

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I believe it looks better with the proper syntax highlight on the json. I'll change it so the filename is in the title

@msimberg
Copy link
Collaborator

msimberg commented Jun 5, 2025

@mpasserini would you still like to have a look at the changes here?

@fawzi
Copy link
Contributor

fawzi commented Jun 5, 2025

I am working some changes to add some information for practical use and performance hints (will add an MR soon), but @lukasgd pointed out that there is an alsp/storage, I think that it should go be something be added to alps/hardware, and link to doc/storage, it it not a good idea to have two places in my opinion, we should consolidate, and docs/storage seems a better place to me...

@msimberg msimberg requested a review from bcumming June 5, 2025 18:57
@bcumming
Copy link
Member

bcumming commented Jun 6, 2025

I think these changes are okay to merge: they remove out-of-date information (that was cut and pasted by me from the KB docs), and improve the quality of what is written already.

The discussion about how to organise the Storage docs and start contributing more useful guidance on how to use storage is a separate topic.

@bcumming bcumming merged commit 3f0bdb9 into eth-cscs:main Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants