-
Notifications
You must be signed in to change notification settings - Fork 41
Storage doc updates and fixes #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
msimberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor style comments. Can't comment on the contents themselves, but looks good to me on a high level.
Co-authored-by: Mikael Simberg <[email protected]>
404e311 to
2af84e4
Compare
docs/storage/object.md
Outdated
|
|
||
| First, a bucket policy needs to be written: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ```json | |
| ```console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I believe it looks better with the proper syntax highlight on the json. I'll change it so the filename is in the title
|
@mpasserini would you still like to have a look at the changes here? |
|
I am working some changes to add some information for practical use and performance hints (will add an MR soon), but @lukasgd pointed out that there is an alsp/storage, I think that it should go be something be added to alps/hardware, and link to doc/storage, it it not a good idea to have two places in my opinion, we should consolidate, and docs/storage seems a better place to me... |
|
I think these changes are okay to merge: they remove out-of-date information (that was cut and pasted by me from the KB docs), and improve the quality of what is written already. The discussion about how to organise the Storage docs and start contributing more useful guidance on how to use storage is a separate topic. |
No description provided.