Skip to content

Conversation

@msimberg
Copy link
Collaborator

@msimberg msimberg commented Jun 11, 2025

Enables the spell checker CI action again with a revised workflow. This now uses pull_request_target for the action context, so that PRs from forks can have comments posted on the PR.

The workflow broke previously because the prerelease branch was force-pushed and the old pinned commit was removed. I'm keeping the pinned commit since this is running with the pull_request_target event because of security considerations, even if it may mean it breaks again in the future. If that happens, most likely only the commit needs to be updated.

As before, the reporting may be too verbose, in which case we need to silence this a bit, but that can be changed over time.

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

2 similar comments
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@msimberg msimberg closed this Jun 11, 2025
@msimberg msimberg reopened this Jun 11, 2025
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

4 similar comments
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@msimberg msimberg closed this Jun 11, 2025
@msimberg msimberg reopened this Jun 11, 2025
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/150

@msimberg msimberg force-pushed the reenable-spell-check branch from af89271 to 9f968be Compare July 8, 2025 13:44
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/150

@msimberg
Copy link
Collaborator Author

msimberg commented Jul 8, 2025

I'm going to force merge this for testing. With the pull_request_target event this workflow isn't going to run until it's merged to main. The workflow runs somewhat ok with pull_request but can't comment on the PR. Merging to make sure that the pull_request_target event also works.

@msimberg msimberg marked this pull request as ready for review July 8, 2025 14:29
@msimberg msimberg merged commit fdad4c9 into eth-cscs:main Jul 8, 2025
1 check passed
@msimberg msimberg deleted the reenable-spell-check branch July 8, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant