Skip to content

Conversation

@bcumming
Copy link
Member

@bcumming bcumming commented Jun 24, 2025

@bcumming bcumming requested review from RMeli and msimberg as code owners June 24, 2025 15:39
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

Co-authored-by: Mikael Simberg <[email protected]>
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

bcumming and others added 2 commits June 25, 2025 15:46
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

1 similar comment
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, but this looks great. Thanks @bcumming.


!!! info "Quick affinity checks"

The Slurm flag [`cpu-bind=verbose`](https://slurm.schedmd.com/srun.html#OPT_cpu-bind) prints information about MPI ranks and their thread affinity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Slurm flag [`cpu-bind=verbose`](https://slurm.schedmd.com/srun.html#OPT_cpu-bind) prints information about MPI ranks and their thread affinity.
The Slurm flag [`--cpu-bind=verbose`](https://slurm.schedmd.com/srun.html#OPT_cpu-bind) prints information about MPI ranks and their thread affinity.

bcumming and others added 2 commits June 25, 2025 17:25
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

1 similar comment
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

Co-authored-by: Mikael Simberg <[email protected]>
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/167

@bcumming bcumming merged commit 9335b9f into eth-cscs:main Jun 25, 2025
1 check passed
@bcumming bcumming deleted the slurm/zen2 branch June 30, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants