Skip to content

CI/CD full port from KB #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 8, 2025
Merged

CI/CD full port from KB #169

merged 10 commits into from
Jul 8, 2025

Conversation

@finkandreas
Copy link
Collaborator

@finkandreas finkandreas commented Jun 30, 2025

No description provided.

@finkandreas finkandreas marked this pull request as draft June 30, 2025 10:14
@github-actions
Copy link

github-actions bot commented Jun 30, 2025

preview available: https://docs.tds.cscs.ch/169

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

preview available: https://docs.tds.cscs.ch/169

@finkandreas finkandreas marked this pull request as ready for review July 4, 2025 13:57
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

preview available: https://docs.tds.cscs.ch/169

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

preview available: https://docs.tds.cscs.ch/169

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

preview available: https://docs.tds.cscs.ch/169

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

preview available: https://docs.tds.cscs.ch/169

bcumming
bcumming approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@bcumming bcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andreas - that is a lot of documentaiton.

It would be good to apply some of the best practices more consistently, for example the "one sentence per line" rule:

https://docs.cscs.ch/contributing/#text-formatting

However, in the interest of getting the existing documentation ported, let's leave that as a folllow up activity when you update and revise individual sections of the docs.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/169

msimberg
msimberg requested changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor formatting nit at this point. Agree with @bcumming, let's get this in as it is and improve over time.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

preview available: https://docs.tds.cscs.ch/169

@bcumming bcumming enabled auto-merge July 8, 2025 06:30
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

preview available: https://docs.tds.cscs.ch/169

@bcumming bcumming added this pull request to the merge queue Jul 8, 2025
Merged via the queue into eth-cscs:main with commit cc4566e Jul 8, 2025
1 check passed
@finkandreas finkandreas deleted the cicd-kb-port branch July 11, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msimberg msimberg msimberg approved these changes

@bcumming bcumming bcumming approved these changes

@RMeli RMeli Awaiting requested review from RMeli RMeli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@finkandreas @msimberg @bcumming