Avoid port 6000 in pytorch #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optionally add warning somewhere?
|
preview available: https://docs.tds.cscs.ch/178 |
teojgo
approved these changes
Jul 2, 2025
Collaborator
|
I'll merge this right away to have it in the docs, but please do follow up with another PR adding a warning if you can. |
bcumming
approved these changes
Jul 2, 2025
| ################################# | ||
| export MASTER_ADDR=$(hostname) # (3)! | ||
| export MASTER_PORT=6000 | ||
| export MASTER_PORT=29500 |
Member
There was a problem hiding this comment.
How about adding a comment to this line about why?
Contributor
Author
There was a problem hiding this comment.
+1 @bcumming, wording? something like:
Please avoid common ports like 6000, 60000 or <1024 which may be used by another service and could cause a silent tcp socket timeout.
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionally add warning somewhere?