MLP tutorials update #209
MLP tutorials update #209
Conversation
lukasgd
requested review from
RMeli,
bcumming,
msimberg and
rsarm
as code owners
|
preview available: https://docs.tds.cscs.ch/209 |
RMeli
left a comment
RMeli
left a comment
There was a problem hiding this comment.
Mostly nitpicks (they can be accepted/rejected from the GitHub UI), but otherwise LGTM.
I think it is good to switch from console to bash in most cases (bash should not have the shell prompt $), but console should be preferred when there is a mix of commands and output (commands need the prompt $) or when it is important to show the prompt modification (as in virtual environments).
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
1 similar comment
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
Co-authored-by: Rocco Meli <[email protected]>
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
2 similar comments
|
preview available: https://docs.tds.cscs.ch/209 |
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
…mention login-node policies
|
preview available: https://docs.tds.cscs.ch/209 |
|
preview available: https://docs.tds.cscs.ch/209 |
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
Co-authored-by: Rocco Meli <[email protected]>
|
preview available: https://docs.tds.cscs.ch/209 |
|
As discussed with @RMeli, I've reverted the bash blocks to console and made explicit where a command is run by adding the hostname and possibly virtual environment to the shell prompt. I've also added a paragraph about the login node policy. |
3 participants
This updates the existing MLP tutorials, to be merged with ML software in a next step. Also for the future, a Megatron-LM tutorial with recommended settings is left.