-
Notifications
You must be signed in to change notification settings - Fork 41
Move MLP tutorials under software, add CE section to Pytorch including best practice for large-scale training #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1418931
Moved MLP tutorials under software, added CE section to Pytorch
lukasgd a0fc65a
Merge branch 'main' into mlp-tutorials-update-iii
lukasgd 5109d87
Update docs/build-install/containers.md
lukasgd 34bbcf8
Update docs/build-install/containers.md
lukasgd 5a62e5c
Update docs/platforms/mlp/index.md
lukasgd 9c1c90a
Update docs/software/ml/pytorch.md
lukasgd 2c4381f
Update docs/software/ml/pytorch.md
lukasgd 6c9b1a5
Update docs/software/ml/pytorch.md
lukasgd 7c580b8
Update docs/software/ml/pytorch.md
lukasgd 42082ce
Update docs/software/ml/pytorch.md
lukasgd c4e9cb6
Update docs/software/ml/pytorch.md
lukasgd 61b0ffe
Update docs/software/ml/pytorch.md
lukasgd 6d22e8d
Update docs/software/ml/pytorch.md
lukasgd d438dcd
Integrating Fabian's feedback, updating code owners
lukasgd 205d4b5
Merge branch 'main' into mlp-tutorials-update-iii
lukasgd 2c7904c
Updating known issues
lukasgd ef0fdf6
Update check-spelling metadata
lukasgd f099e3c
Update docs/build-install/containers.md
bcumming 9862ec3
Update docs/software/ml/index.md
bcumming 48ccb03
Update docs/software/ml/tutorials/index.md
bcumming c1c72e7
Update docs/software/ml/pytorch.md
bcumming bedceb6
move ml tutorials into a tutorials section
bcumming c5383db
small cleanup
bcumming cfe4fe8
Merge branch 'mlp-tutorials-update-iii' of github.com:lukasgd/cscs-do…
bcumming 998eefd
fix links; add more links to ML tutorials/pytorch; add guides/tutoria…
bcumming 17e0eff
Merge branch 'main' into mlp-tutorials-update-iii
bcumming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| JAX | ||
| nvitop | ||
| NVRTC | ||
| placeholders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,4 +91,4 @@ Project is per project - each project gets a project folder with project-specifi | |
|
|
||
| ## Guides and tutorials | ||
|
|
||
| Tutorials for fine-tuning and running inference of LLMs as well as training an LLM with Nanotron can be found in the [MLP Tutorials][ref-guides-mlp-tutorials] page. | ||
| Tutorials on how to set up and configure a machine learning environment in order to run LLM workloads such as inference, fine-tuning and multi-node training can be found in the [tutorials section][ref-software-ml-tutorials]. | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not a good a idea to duplicate the command as you already linked it above. Also 64MB still seems a bit little for full striping, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation that this keeps reappearing. Since it seems largely ignored by users and has caused job interference previously, I think repeating it doesn't harm. But probably we should think about a new default as this is complicated to remember for the average user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove the repetition for now please? so we only have 1 place to change after, and we can add it back once that is done...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Henrique.
I have updated the docs to:
This makes the commands explicit, but let's us provide guidance on specific flags in one location.