-
Notifications
You must be signed in to change notification settings - Fork 41
Added devportal #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added devportal #251
Conversation
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/251 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/251 |
This comment has been minimized.
This comment has been minimized.
|
Thanks @jpdorsch! I'll have a closer look later, but for the spell checker you can add oauth, oidc, and wso to https://github.com/eth-cscs/cscs-docs/blob/main/.github/actions/spelling/allow.txt. |
This comment has been minimized.
This comment has been minimized.
|
preview available: https://docs.tds.cscs.ch/251 |
This comment has been minimized.
This comment has been minimized.
|
Hi @msimberg , I see that Cheers |
|
preview available: https://docs.tds.cscs.ch/251 |
Ah right. Depends, is "WSO" on its own a valid term? If yes, then you can indeed leave WSO as is in Same goes for "OAuth" vs "OAuth2". |
|
I see, let me change it then, because |
|
preview available: https://docs.tds.cscs.ch/251 |
msimberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor nits from my side on the text.
Please add the developer portal to the index page of "Services" as well.
|
preview available: https://docs.tds.cscs.ch/251 |
bcumming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a comment about the screenshots. Most of the shots are really useful for readers, but I have marked a few that might not be needed.
https://docs.cscs.ch/contributing/#screenshots
The suggestion is to keep screenshots to a minimum to make docs clearer, and keep the repo size down. Feel free to argue for their inclusion, or zoom / label some to better integrate them with the text.
|
preview available: https://docs.tds.cscs.ch/251 |
|
preview available: https://docs.tds.cscs.ch/251 |
|
preview available: https://docs.tds.cscs.ch/251 |
|
preview available: https://docs.tds.cscs.ch/251 |
bcumming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
In this PR:
services/devportalas documentation for the Developer Portal (before attached to FirecREST docs)CODEOWNERSoffirecrestanddevportalfirecresttoserviceswith the prefixdevportal-*https://docs.tds.cscs.ch/251/services/devportal/#creating-an-application