-
Notifications
You must be signed in to change notification settings - Fork 41
Better document CUDA_CACHE_PATH in CP2K docs
#43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's set by default on daint.
|
preview available: https://docs.tds.cscs.ch/43 |
|
I will leave it to @RMeli to comment definitively. I think that documenting this variable is important - even if it is defined by default on the system. |
|
As I expressed elsewhere, I think it would be beneficial to have a central (and by-platform) documentation of all these variables that are automatically set by us, so that users are aware. If we want to be consistent with However, an alternative that is probably nicer for the end-user would be to explicitly set both (doesn't hurt), and add a note that they are here only for documentation purposes and they are already automatically set in the system? In such case I would do what @msimberg suggest and set it to the actual default |
|
Sorry @msimberg, I misread your suggestion. I agree |
…launch scripts despite them being set on the HPC platform by default
|
I agree with @RMeli, leaving it in the documentation does not hurt, even if there is a reasonable default on each cluster. A lot of time would have been saved on the validation of Alps last summer if this kind of stuff had remained in the docs (IIRC, something similar happened when Daint XC was tested, but the knowledge was lost). |
|
preview available: https://docs.tds.cscs.ch/43 |
|
All your comments are good! I just pushed a change to restore Do you have a preference for keeping the other box mentioning I added a link to the new "GPU-aware MPI" section from the CP2K info box (35f48db). |
|
preview available: https://docs.tds.cscs.ch/43 |
At this point I'd go for consistency and add another mentioning |
|
preview available: https://docs.tds.cscs.ch/43 |
Absolutely worth it. I pushed a change, mind having a look? I used slightly different wording in the new info box compared to the code annotation. Not sure if it's worth just copy pasting the two to be exactly the same... |
RMeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
CUDA_CACHE_PATH in CP2K docsCUDA_CACHE_PATH in CP2K docs
It's set by default on daint (to a different value).
Only reason to keep it here is if we expect many users to be running CP2K on other clusters, but then I'd rather make sure
CUDA_CACHE_PATHis set by default there instead?