Added Docs for Firecrest v2 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
preview available: https://docs.tds.cscs.ch/49 |
|
preview available: https://docs.tds.cscs.ch/49 |
Co-authored-by: Ben Cumming <[email protected]>
|
preview available: https://docs.tds.cscs.ch/49 |
RMeli
reviewed
Mar 20, 2025
Member
RMeli
left a comment
RMeli
left a comment
There was a problem hiding this comment.
LGTM, just a few suggestions/nitpicks (most of which you can easily accept/reject from the GitHub UI).
|
preview available: https://docs.tds.cscs.ch/49 |
bcumming
approved these changes
Mar 21, 2025
|
preview available: https://docs.tds.cscs.ch/49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to keep all in the same page as v1, but pointing out that is preferable to use v2.