Skip to content

Conversation

@RMeli
Copy link
Member

@RMeli RMeli commented Mar 20, 2025

No description provided.

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@RMeli RMeli marked this pull request as ready for review March 20, 2025 13:44
@RMeli RMeli requested review from bcumming and msimberg as code owners March 20, 2025 13:44
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

Co-authored-by: Mikael Simberg <[email protected]>
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@RMeli RMeli requested a review from msimberg March 20, 2025 20:56
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

1 similar comment
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

1 similar comment
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

1 similar comment
@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @RMeli!

I applied some changes to split/merge lines to have one sentence per line. I realized only after I applied changes that you may intentionally have split lines on commas as well, which may be a good guideline to follow as well. Sorry for the back and forth.

I will open a PR with a basic "style guide" and we can bikeshed the formatting there. Ideally it'd be automatically enforced instead of subjectively applied by the reviewer...

@github-actions
Copy link

preview available: https://docs.tds.cscs.ch/51

@msimberg msimberg merged commit 55247f4 into main Mar 21, 2025
1 check passed
@msimberg msimberg deleted the rmeli/cp2k branch March 21, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants