Skip to content

Conversation

@RMeli
Copy link
Member

@RMeli RMeli commented Apr 1, 2025

I think the current description of the spack view is misleading. I tried to improve things, trying to make clear that the spack view sets some environment variables that are not automatically used by Spack.

@RMeli RMeli requested review from bcumming and msimberg as code owners April 1, 2025 09:22
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

preview available: https://docs.tds.cscs.ch/70

2 similar comments
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

preview available: https://docs.tds.cscs.ch/70

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

preview available: https://docs.tds.cscs.ch/70

@github-actions
Copy link

github-actions bot commented Apr 1, 2025

preview available: https://docs.tds.cscs.ch/70

@bcumming bcumming merged commit b35f31a into main Apr 1, 2025
1 check passed
@bcumming bcumming deleted the rmeli-spack-view branch April 1, 2025 09:51
You can then set the uenv as an [upstream Spack instance](https://spack.readthedocs.io/en/latest/chain.html) as follows:

```bash
export SPACK_SYSTEM_CONFIG_PATH=$UENV_SPACK_CONFIG_PATH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but may be dangerous if users don't know to use separate indexes, user config paths, etc. per uenv. I don't know if we want/need to provide a full guide on how to do that (I can share what I do), but a warning may be useful at least at this point?

Copy link
Member Author

@RMeli RMeli Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged too quickly. =)

I actually did not realize that the reminder of the documentation was about uenv-spack; I thought it was still very much WIP and undocumented. Therefore, the above is probably bad for the end user, which should be encouraged to use the tool (I suppose). I can rephrase it to make it clearer that things are not set automatically but one should do so if they wish (without giving too many suggestions).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize either 😬 Yeah, I think the idea is that the uenv-spack tool consumes UENV_SPACK_CONFIG_PATH etc. but it sets up a clone of spack etc. on its own, right? If that's the case, exporting SPACK_SYSTEM_CONFIG_PATH here probably isn't going to harm anyone, but it won't help either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants