Skip to content

Add bad nodes in SlurmGPUGresTest sanity message #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgphpc merged 3 commits into from
Jan 12, 2026
Merged

Add bad nodes in SlurmGPUGresTest sanity message #495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b864b3a
Add bad nodes in SlurmGPUGresTest sanity message
ekouts Jan 6, 2026
e41285e
Fix node count
ekouts Jan 6, 2026
e0ed855
Fix formatting
ekouts Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions checks/system/slurm/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,11 +578,20 @@ def assert_gres_valid(self):
gpu_count = self.current_partition.select_devices('gpu')[0].num_devices
part_re = rf'Partitions=\S*{partition_name}'
gres_re = rf'gres/gpu={gpu_count} '
node_count = sn.count(sn.extractall(part_re, self.stdout))
gres_count = sn.count(
sn.extractall(rf'{part_re}.*{gres_re}', self.stdout))
return sn.assert_eq(
node_count, gres_count,
f'{gres_count}/{node_count} of '
f'{partition_name} nodes satisfy {gres_re}'
node_re = r'NodeName=(\S+)'

all_nodes = sn.evaluate(
sn.extractall(rf'{node_re}.*{part_re}', self.stdout, 1)
)
good_nodes = sn.evaluate(
sn.extractall(rf'{node_re}.*{part_re}.*{gres_re}',
self.stdout, 1)
)
bad_nodes = ','.join(sorted(set(all_nodes) - set(good_nodes)))

return sn.assert_true(
len(bad_nodes) == 0,
msg=(f'{len(good_nodes)}/{len(all_nodes)} of '
f'{partition_name} nodes satisfy {gres_re}. Bad nodes: '
f'{bad_nodes}')
)