Update DcgmRpmCheck after maintenance failure#497
Merged
jgphpc merged 2 commits intoeth-cscs:mainfrom Jan 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a test failure in DcgmRpmCheck by ensuring deterministic output ordering when checking DCGM library checksums. The test was failing due to inconsistent ordering from the shasum command's output.
Changes:
- Added
|sortto theshasumcommand indcgm_rpm.shto ensure consistent alphabetical ordering - Updated the reference file
3.3.6.refto reflect the new sorted order of library checksums
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| checks/system/gssr/src/rpm/dcgm_rpm.sh | Added sort pipe to ensure deterministic ordering of shasum output |
| checks/system/gssr/src/rpm/3.3.6.ref | Updated reference file with alphabetically sorted checksums to match new script behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
cscs-ci run alps-daint-uenv;MY_UENV=prgenv-gnu/25.11:v1 |
gppezzi
approved these changes
Jan 15, 2026
Collaborator
gppezzi
left a comment
gppezzi
left a comment
There was a problem hiding this comment.
tested on clariden and daint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reframe -c checks/system/gssr/dcgm_hook.py -n DcgmRpmCheck -r -J A=csstaff