Merged
Conversation
Add clang-format GitHub action and format the files
Fix calculation of bandwidth in MiB/s
Collaborator
Author
|
Needs #24 to be merged to main, the uenv image used by reframe-ci pipeline is not available after the extraordinary maintenance. |
Update uenv of the reframe-ci branch CI pipeline
e148138 to
c79f7ee
Compare
Collaborator
Author
|
The error is unrelated, the FFT benchmark has not been modified. So merging this.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang-format changes and bandwidth unit fixed.
This PR also modifies how reframe is installed, we now use the reframe pip package instead of bootstrapping. When the extraordinary maintenance happened, the uenv v5 was not available anymore, so we used v10 but this didn't allow bootstrapping because of missing libxml2 and libxslt, it's cleaner now.