Add support streamer data transfers#197
Merged
ekouts merged 14 commits intoeth-cscs:mainfrom Dec 23, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for streamer-based data transfers as an alternative to S3, enabling more flexible file transfer options. It also modernizes the Python version requirements by dropping Python 3.7 support and adding support for Python 3.10-3.12.
Key changes:
- Introduces streamer transfer method alongside existing S3 method for both uploads and downloads
- Adds
firecrest-streamer>=0.00.21dependency and corresponding mypy configuration - Updates Python version support from 3.7+ to 3.8+ with explicit support through 3.12
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates Python version classifiers (removes 3.7, adds 3.10-3.12), sets minimum to 3.8, and adds firecrest-streamer dependency |
| firecrest/v2/_sync/Client.py | Adds ExternalTransfer base class, implements streamer upload/download methods, updates transfer_method parameter validation, and adds wait_for_streamer_job_to_listen logic |
| firecrest/v2/_async/Client.py | Mirrors sync client changes with async equivalents for streamer transfers and job waiting |
| firecrest/utilities.py | Adds sched_state_running helper function to detect running job states |
| .mypy.ini | Adds streamer module to ignore_missing_imports configuration |
| .github/workflows/testing.yml | Updates test matrix to remove Python 3.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rsarm
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be better to merge after eth-cscs/firecrest-v2#169, so that we also pin the version to the latest firecrest-streamer