Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the v2 synchronous and asynchronous clients to tolerate FirecREST responses that return camelCase-only fields (post v2.5.0), primarily within transferDirectives for external upload/download flows.
Changes:
- Add camelCase fallbacks for multipart upload/download directive fields (e.g.,
partsUploadUrls,maxPartSize,completeUploadUrl,downloadUrl). - Update transfer-method selection to read
transferMethod(camelCase) in one path per client (sync download, async upload).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
firecrest/v2/_sync/Client.py |
Adds camelCase directive fallbacks for external transfer helpers; updates download() to read transferMethod. |
firecrest/v2/_async/Client.py |
Adds camelCase directive fallbacks for external transfer helpers; updates upload() to read transferMethod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rsarm
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After version 2.5.0 (PR: eth-cscs/firecrest-v2#180), the responses will include only camelcase fields.