Open
Conversation
This is currently unable to retrieve outputs after function execution. I will have to rework a part of the memory model.
wasm backend finally works on matmul now. Fixed a few bugs I had introduced in input writing and context base offsets.
I tested on wasm backend, not on cheri
The wasm memory is still of fixed size, but we can now provide our own buffer for it, which can be on the heap as well. This is optional, and can be toggled easily.
...when using heap for wasm memory.
removes heapless wasm memory initialization as announced in #13 (comment)
and fixing a bug in memory read
…into dev/wasmtime
I don't know why the solution with the constant did not work, but compiling server crate with feature "wasmtime-precompiled" did not make it "true".
tom-kuchler
requested changes
Feb 22, 2024
Collaborator
|
Also should add the new features to the workflow so they will be tested on updates (need to resolve the merge conflicts for the workflow to run as I understand) |
Collaborator
Author
|
Collaborator
Author
|
The |
Contexts are allowed to allocate a larger amount of memory than they were asked for. This specifically is a requirement for the Wasm backends, where the Wasm standard dictates the Wasm memory to be a multiple of the Wasm page size (64Kib), so we need to round up to the next multiple. This mainly adapts the OOB tests to take the actual context size into account.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Wasmtime backend using Wasmtime for function isolation. The backend has two flavors:
dandelion-wasmtime-jitdandelion-wasmtime-precomp