Separate Detour for LOVE version < 11.5

[AxBolduc]

As I explained in #145 the luaL_loadbufferx detour that lovely uses doesn't get hit for games that use LOVE versions before 11.5 (In my case 11.4). Instead of luaL_loadbufferx love.dll calls luaL_loadbuffer which has a very similar signature.

This is a pretty crude implementation that uses the windows API to get the version number on love.dll and uses that to determine which detour to use for the game at runtime.

Super open to feedback as I'm not sure that this is the best solution.

[ethangreen-dev]

Hey @AxBolduc, thanks for the PR!

You're definitely on the right track but you can simplify things by calling love.version instead of scraping the module's PE header via win32. (https://github.com/love2d/love/blob/1462bd47cf222885c182878950d3f3c10ad92380/src/modules/love/love.cpp#L288).

[AxBolduc]

@ethangreen-dev Thanks for finding that function for me, definitely better than using the win32 apis. I took a crack at calling the function from the dll and this currently works. Let me know if there was a better way for me to make the external call I just used the logic that we use to load the luaL_loadbuffer function.

[ethangreen-dev]

You can copy how we dynamically load lua51 functions in the sys module (It's alright to add the libloading dependency to lovely-win):

lovely-injector/crates/lovely-core/src/sys.rs

Line 20 in 2362019

pub static LUA_LIB: Lazy<Library> = Lazy::new(|| unsafe { Library::new("lua51.dll").unwrap() });

Keep it in the windows crate as we'll figure out other platforms in a different PR.

[AxBolduc]

@ethangreen-dev Took another crack at it. Let me know if there's anything else we want to clean up.

[ethangreen-dev]

@AxBolduc Sorry for the delay, we've had our hands full with other tasks. This PR should be moved over to use the functionality implemented in #198. If complete on time I think that this will fit nicely into the merge window for the next release.

[WilsontheWolf]

Is this PR still relevant? #305 seems to implement a similar change, not sure if it fixed the issue this was meant to close or not.