Merged
Conversation
Contributor
Author
|
also fixed knockback in the dev instance |
ethanicusss
reviewed
Feb 28, 2026
ethanicusss
reviewed
Feb 28, 2026
| Text title = new TranslatableText(AstralAdditions.MOD_ID + ".music." + key + ".title"); | ||
| Text artist = new TranslatableText(AstralAdditions.MOD_ID + ".music." + key + ".artist"); | ||
| NowPlayingHud.show(title, artist); | ||
| } |
Owner
There was a problem hiding this comment.
Issue: Ah sorry this system won't really work for giving credit, since it only discriminates between sound categories rather than individual sounds. The category music_ow_day has a selection of 9 different tracks, mostly from vanilla, but also with two tracks from Winter and one from Sol.
With this system, the best we could do is say "Overworld music, by Mojang, Winter or Sol"
It has to discriminate between the actual sounds for us to credit properly.
Contributor
Author
There was a problem hiding this comment.
Ah ok, I see, makes sense I shall fix later on tonight, also gives me a chance to like add the config settings.
Could I get a list of what song is made by who?
increase time showing and fade time, to make it easier to read in the time added a third line "Now playing..." at the top, text from en_us.json
jank string concat but it works. not sure what the intentional way of concatting Text is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added music display!!!
Also cleaned up some bits
Removed the old desizer blocks, so now we only got the caseing and controller, to help de clutter the REI
I would like to add a config to change postion of the music display, and the size too