Skip to content

Changeset: class-ify some objects to improve readability #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Changeset: class-ify some objects to improve readability #5298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0a3a3b
Changeset: Turn `textLinesMutator()` into a real class
rhansen Mar 21, 2021
15e3e48
Changeset: Turn `newOp()` into a real class
rhansen Oct 25, 2021
3e0e428
Changeset: Throw on unexpected chars while iterating ops
rhansen Oct 21, 2021
d36f79f
Changeset: Turn `opIterator()` into a real class
rhansen Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* `opAttributeValue()`
* `appendATextToAssembler()`: Deprecated in favor of the new `opsFromAText()`
generator function.
* `newOp()`: Deprecated in favor of the new `Op` class.

# 1.8.15

Expand Down
4 changes: 2 additions & 2 deletions src/node/utils/padDiff.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ PadDiff.prototype._createDeletionChangeset = function (cs, startAText, apool) {
let curChar = 0;
let curLineOpIter = null;
let curLineOpIterLine;
let curLineNextOp = Changeset.newOp('+');
let curLineNextOp = new Changeset.Op('+');

const unpacked = Changeset.unpack(cs);
const csIter = Changeset.opIterator(unpacked.ops);
Expand Down Expand Up @@ -302,7 +302,7 @@ PadDiff.prototype._createDeletionChangeset = function (cs, startAText, apool) {
}

if (!curLineNextOp.chars) {
curLineNextOp = curLineOpIter.hasNext() ? curLineOpIter.next() : Changeset.newOp();
curLineNextOp = curLineOpIter.hasNext() ? curLineOpIter.next() : new Changeset.Op();
}

const charsToUse = Math.min(numChars, curLineNextOp.chars);
Expand Down
Loading