Skip to content

fix: catch all errors that can occur during plugin installation and log the error #7375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamTV12345 wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −2
Open

fix: catch all errors that can occur during plugin installation and log the error #7375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/.npmrc
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion src/static/js/pluginfw/installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@ export const checkForMigration = async () => {

for (const plugin of installedPlugins.plugins) {
if (plugin.name.startsWith(plugins.prefix) && plugin.name !== 'ep_etherpad-lite') {
await linkInstaller.installPlugin(plugin.name, plugin.version);
try {
await linkInstaller.installPlugin(plugin.name, plugin.version);
} catch (e) {
logger.error(`Error installing plugin ${plugin.name} with version ${plugin.version}: ${e}`);
}
}
}
};
Expand Down
Loading