Added minBaseFee and DA Footprint config sections #1830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
reviewed
Nov 4, 2025
geoknee
requested changes
Nov 4, 2025
Contributor
geoknee
left a comment
geoknee
left a comment
There was a problem hiding this comment.
Some tweaks needed.
Generally it would be better to put something under "features", because as-is we are only really helping out fresh chains which can set values at genesis. We are missing instructions for existing chains to modify / configure the feature at "runtime".
Best thing would be to put most material in "features" and then link to there from rollup deploy config.
Comment on lines
550
to
562
| #### minBaseFee | ||
|
|
||
| Allows chain operators to specify a minimum base fee to help shorten the length of priority fee auctions. | ||
| The `minBaseFee` is an absolute minimum expressed in wei. | ||
| 0 disables the `minBaseFee` entirely (disabled by default). | ||
|
|
||
| * **Type:** Number | ||
| * **Default value:** 0 | ||
| * **Recommended value:** 100000 wei | ||
| * **Notes:** Setting the minimum too high may make transactions harder to get included for users. [See the specs for more detail](https://specs.optimism.io/protocol/jovian/exec-engine.html#minimum-base-fee). | ||
| * **Standard Config Requirement:** none | ||
| *** | ||
|
|
Contributor
There was a problem hiding this comment.
This seems good!
- We should add something about how to actually configure this via the
SystemConfig. - there are some standard config requirements, pending governance jovian: add bounds for minimum base fee in standard config superchain-registry#1127
This was
linked to
issues
Nov 5, 2025
Collaborator
Author
|
@geoknee I updated the stand config value requirement for minBaseFee. As for creating the more detailed feature docs for these I agree but I think it would be best to do those as seperate PR's. Wdyt? |
geoknee
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1710
#1742