-
Notifications
You must be signed in to change notification settings - Fork 108
feat(proxyd): add healthcheck and drain functionality from Uniswap fork #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proxyd): add healthcheck and drain functionality from Uniswap fork #534
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
jelias2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, look forward to landing this!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #534 +/- ##
==========================================
+ Coverage 57.61% 57.64% +0.02%
==========================================
Files 93 94 +1
Lines 13985 14201 +216
==========================================
+ Hits 8058 8186 +128
- Misses 5440 5518 +78
- Partials 487 497 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Jacob Elias <[email protected]>
0df18a8 to
296bc5e
Compare
#2) Changes: - Set graceful_shutdown_seconds default to 0 (no delay) instead of 10s - Remove graceful_shutdown_seconds = 0 from all test configs (no longer needed) - Fix transport resource leak in ProbeWorker by closing connections on Stop() - Make Drain() actually reject new RPC and WebSocket requests during drain period Rationale: The healthcheck and drain functionality should be disabled by default. The previous 10-second default forced unnecessary changes to all existing test configurations. Now configs only need to set graceful_shutdown_seconds if they want to enable the drain delay. Co-authored-by: Claude Sonnet 4.5 <[email protected]>
Description
Original PR description:
Tests
Added testing for common healthcheck results based on server responses - success, failure, and redirect
Additional context
From original PR:
Metadata