Skip to content

fix: FIx windows build#549

Merged
jelias2 merged 3 commits intomainfrom
jan/goreleaser
Feb 10, 2026
Merged

fix: FIx windows build#549
jelias2 merged 3 commits intomainfrom
jan/goreleaser

Conversation

@janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Feb 10, 2026

Description

  • Fixes OS-dependent syscall call by providing OS-dependent implementations
  • Updates goreleaser and adds it to mise.toml - this opens up a pathway to use the mise-based CI tooling install

Failing workflow here

Related to ethereum-optimism/optimism#19133
Related to #546

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.74%. Comparing base (b257304) to head (b15fbd1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   57.65%   57.74%   +0.09%     
==========================================
  Files          94       95       +1     
  Lines       14225    14227       +2     
==========================================
+ Hits         8201     8215      +14     
+ Misses       5524     5512      -12     
  Partials      500      500              
Flag Coverage Δ
cci-stats 0.48% <ø> (ø)
op-acceptor 58.92% <ø> (+0.17%) ⬆️
op-signer 47.32% <ø> (ø)
op-txproxy 31.81% <ø> (ø)
peer-mgmt-service 8.48% <ø> (ø)
proxyd 71.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
proxyd/backend_probe.go 88.39% <100.00%> (ø)
proxyd/backend_syscall.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jelias2 jelias2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the file tag proxyd/backend_syscall_windows.go, on //go:build !windows

@jelias2 jelias2 merged commit de49cc1 into main Feb 10, 2026
85 checks passed
@jelias2 jelias2 deleted the jan/goreleaser branch February 10, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants