proxyd: support backend mTLS for websocket upstreams#570
Open
dahu33 wants to merge 2 commits intoethereum-optimism:mainfrom
Open
proxyd: support backend mTLS for websocket upstreams#570dahu33 wants to merge 2 commits intoethereum-optimism:mainfrom
dahu33 wants to merge 2 commits intoethereum-optimism:mainfrom
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 57.83% 58.02% +0.19%
==========================================
Files 96 96
Lines 14501 14515 +14
==========================================
+ Hits 8386 8423 +37
+ Misses 5597 5570 -27
- Partials 518 522 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates proxyd backend TLS handling so the same backend TLS config is applied to both HTTP and WebSocket upstream connections.
It also fixes
configureBackendTLSso a backend client certificate/key pair can be used without requiringca_fileto be set. In that case proxyd builds adefault
tls.Configand still attaches the configured client certificate for mTLS.Changes
tls.Configto the outbound WebSocket dialerclient_cert_file+client_key_filewithout requiringca_fileconfigureBackendTLSwith cert-only and CA+cert configurationsWithTLSConfigwiring for both HTTP and WebSocket backend clientsTesting
go test .go test ./... -run 'TestConfigureBackendTLS|TestWithTLSConfigAppliesToHTTPAndWebsocketClients'