basefee + debug logs #725
Open
basefee + debug logs #725
+128
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
| // the necessary steps to create accounts and reverses the state in case of an | ||
| // execution error or failed value transfer. | ||
| func (evm *EVM) Call(caller common.Address, addr common.Address, input []byte, gas uint64, value *uint256.Int) (ret []byte, leftOverGas uint64, err error) { | ||
| fmt.Println("evm.go ~ EVM ~ Call ~ Calling contract", caller, addr, string(input[:10]), gas, value) |
There was a problem hiding this comment.
Denial of Service (DoS): unbounded debug logging in EVM.Call
A stray fmt.Println in core/vm/evm.go within the hot-path EVM.Call method emits a log on every contract invocation, risking I/O saturation and node unresponsiveness under high load.
Remove or gate the debug fmt.Println calls behind a configurable log level (e.g., debug-only) to avoid unbounded logging in production.
Suggested change
| fmt.Println("evm.go ~ EVM ~ Call ~ Calling contract", caller, addr, string(input[:10]), gas, value) |
Don't like this finding? Reply "dismiss" and it won't appear again in future scans.
If it's acknowledged or addressed, reply "resolve" to mark it resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests
Additional context
Metadata