Skip to content

op-node: clarify checkSingularBatch comment #18713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeviofCrypto wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −3
Open

op-node: clarify checkSingularBatch comment #18713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions op-node/rollup/derive/batches.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ const (
BatchPast
)

// CheckBatch checks if the given batch can be applied on top of the given l2SafeHead, given the contextual L1 blocks the batch was included in.
// CheckBatch performs semantic validation to check if the given batch can be applied on top of
// the given l2SafeHead, given the contextual L1 blocks the batch was included in.
// The first entry of the l1Blocks should match the origin of the l2SafeHead. One or more consecutive l1Blocks should be provided.
// In case of only a single L1 block, the decision whether a batch is valid may have to stay undecided.
func CheckBatch(ctx context.Context, cfg *rollup.Config, log log.Logger, l1Blocks []eth.L1BlockRef,
Expand All @@ -58,7 +59,8 @@ func CheckBatch(ctx context.Context, cfg *rollup.Config, log log.Logger, l1Block
}
}

// checkSingularBatch implements SingularBatch validation rule.
// checkSingularBatch checks the SingularBatch semantic validation rules on a syntactically-correct
// singular batch.
func checkSingularBatch(cfg *rollup.Config, log log.Logger, l1Blocks []eth.L1BlockRef, l2SafeHead eth.L2BlockRef, batch *SingularBatch, l1InclusionBlock eth.L1BlockRef) BatchValidity {
// add details to the log
log = batch.LogContext(log)
Expand Down Expand Up @@ -190,7 +192,8 @@ func checkSingularBatch(cfg *rollup.Config, log log.Logger, l1Blocks []eth.L1Blo
return BatchAccept
}

// checkSpanBatchPrefix performs the span batch prefix rules for Holocene.
// checkSpanBatchPrefix checks the span batch prefix semantic validation rules for Holocene.
// It validates timestamp ordering and parent hash consistency on a syntactically-correct span batch.
// Next to the validity, it also returns the parent L2 block as determined during the checks for
// further consumption.
func checkSpanBatchPrefix(ctx context.Context, cfg *rollup.Config, log log.Logger, l1Blocks []eth.L1BlockRef, l2SafeHead eth.L2BlockRef,
Expand Down